Skip to content

Shifted handler stack creation to pkg node from pkg rpc #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2020
Merged

Shifted handler stack creation to pkg node from pkg rpc #2

merged 5 commits into from
Mar 24, 2020

Conversation

renaynay
Copy link
Owner

@renaynay renaynay commented Mar 24, 2020 •
edited
Loading

  • shifted handler stack creation to pkg node from pkg rpc, thereby avoiding use of deprecated rpc.NewHTTPServer
  • websocket handler is only added if ws port has been specified as the same as http rpc port, so no unnecessary ws handling if it hasn't been specified

@renaynay renaynay merged commit 631488c into multiplex-http-functional Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@renaynay