Skip to content

fix(npm/pnpm): revert "fix(npm/pnpm): redirect cache and store dir" to attempt to fix pnpm dedupe hanging #36554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix(npm/pnpm): revert "fix(npm/pnpm): redirect cache and store dir" to attempt to fix pnpm dedupe hanging #36554

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eae431a
Revert "fix(npm/pnpm): redirect cache and store dir (#35807)"
karlhorky Jun 17, 2025
a71b2e0
Merge branch 'main' into revert-35807-fix/pnpm/cache-dir
karlhorky Jun 18, 2025
faa4d7c
Merge branch 'main' into revert-35807-fix/pnpm/cache-dir
karlhorky Jun 18, 2025
08d1dd6
Merge branch 'main' into revert-35807-fix/pnpm/cache-dir
karlhorky Jun 19, 2025
e95acc3
Merge branch 'main' into revert-35807-fix/pnpm/cache-dir
karlhorky Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/modules/manager/npm/post-update/pnpm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import type {
} from '../../../../util/exec/types';
import {
deleteLocalFile,
ensureCacheDir,
getSiblingFileName,
localPathExists,
readLocalFile,
Expand Down Expand Up @@ -58,12 +57,8 @@ export async function generateLockFile(
};

const extraEnv: ExtraEnv = {
// those arwe no longer working and it's unclear if they ever worked
NPM_CONFIG_CACHE: env.NPM_CONFIG_CACHE,
npm_config_store: env.npm_config_store,
// these are used by pnpm v5 and above. Maybe earlier versions too
npm_config_cache_dir: await ensureCacheDir('pnpm-cache'),
npm_config_store_dir: await ensureCacheDir('pnpm-store'),
};
const execOptions: ExecOptions = {
cwdFile: lockFileName,
Expand Down