Skip to content

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Sep 16, 2025

Changes

JSONata preset for updating devEngines runtime or packageManager versions - https://docs.npmjs.com/cli/v11/configuring-npm/package-json#devengines

Tested on https://github.com/setchy/renovate-devengines

Context

Please select one of the below:

  • This closes an existing Issue: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: https://github.com/setchy/renovate-devengines

@setchy setchy marked this pull request as draft September 16, 2025 13:26
@setchy setchy changed the title feat(preset): devEngines runtime feat(preset): devEngines versions Sep 16, 2025
@setchy setchy marked this pull request as ready for review September 16, 2025 13:30
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both fields are updated by the npm manager IIRC.

What is the need of preset then?

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should implement it in npm manager instead

@setchy
Copy link
Collaborator Author

setchy commented Sep 16, 2025

we should implement it in npm manager instead

That would be a better solution. I personally wont have the bandwidth to implement this.

@RahulGautamSingh
Copy link
Collaborator

I checked the code. We already extract/detect the package manager versions inside devEngines, but do not update them yet. We only use it to decide the constraints for the package manager to use during lockfile updates.

Issue created: #38067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants