Skip to content

feat: allow configFileNames to be set through env#39144

Merged
jamietanna merged 12 commits into
renovatebot:mainfrom
inomotech-foss:fix/config-file-names
Nov 17, 2025
Merged

feat: allow configFileNames to be set through env#39144
jamietanna merged 12 commits into
renovatebot:mainfrom
inomotech-foss:fix/config-file-names

Conversation

@scootermon

Copy link
Copy Markdown
Contributor

Changes

This PR changes the configFileNames config option (introduced recently in #36644) to support setting it through environment variables as well.
There is a chance I'm missing an obvious reason why it was done this way, but neither the PR nor the corresponding issue mentions one.

Context

Please select one of the below:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@CLAassistant

CLAassistant commented Nov 6, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@RahulGautamSingh RahulGautamSingh self-requested a review November 7, 2025 05:36
Comment thread lib/workers/global/config/parse/index.spec.ts
@RahulGautamSingh

Copy link
Copy Markdown
Collaborator

Please, also test this on a test repo, to be sure.

@scootermon

Copy link
Copy Markdown
Contributor Author

Please, also test this on a test repo, to be sure.

See: https://github.com/scootermon/renovate-test-39144

The onboarding PR is using the correct filename: scootermon/renovate-test-39144#1

and a subsequent run managed to find the file:

DEBUG: Found my-cool-renovate.json5 config file (repository=scootermon/renovate-test-39144)
DEBUG: Repository config (repository=scootermon/renovate-test-39144)
       "fileName": "my-cool-renovate.json5",
       "config": {"$schema": "https://docs.renovatebot.com/renovate-schema.json"}

Comment thread lib/workers/global/config/parse/index.spec.ts
Comment thread lib/workers/global/config/parse/index.spec.ts

@jamietanna jamietanna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussing internally, one potential risk here is that this may lead to API calls increasing for a self-hosted administrator

However, I think it's reasonable to be able to move this from config.js to environment variables/CLI options, given it's already available in the config.js 👍

@jamietanna jamietanna added this pull request to the merge queue Nov 17, 2025
Merged via the queue into renovatebot:main with commit cb1bd5a Nov 17, 2025
39 checks passed
@scootermon scootermon deleted the fix/config-file-names branch November 17, 2025 15:34
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 42.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants