This repository was archived by the owner on Mar 24, 2023. It is now read-only.
Patch empty initcontainers lists #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this, running 'make build' would update web/app/yarn.lock
Rob0h
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Fixed #800 by patching
initContainersthe same way we previously patchedenv,args, andvolumesChanged our makefile invocations of
yarnto use--frozen-lockfile, preventingmake buildfrom updating lockfilesHow I Did it
Added
initContainersto the empty array regexHow to verify it
The integration test that uses a version of the forgeops helm chart that produces an empty
initContainersarrayDescription for the Changelog
Nil
initContainersarrays in helm charts are patched to the empty arrayPicture of a Boat (not required but encouraged)