EPMRPP-104379 || MCP. Tools. Get logs by parent with filter#15
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new MCP tool for fetching logs of test items by parent-item ID, complete with optional filters and default settings.
- Register a new
get_test_item_logs_by_filtertool inserver.go - Introduce a
defaultItemLogLevelconstant inlaunches.go - Implement the tool handler with parameters, filters, and API invocation in
items.go
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/reportportal/server.go | Registered the new toolGetTestItemLogsByFilter with the server |
| internal/reportportal/launches.go | Added defaultItemLogLevel constant for log level default |
| internal/reportportal/items.go | Defined toolGetTestItemLogsByFilter handler and its parameters |
Comments suppressed due to low confidence (2)
internal/reportportal/items.go:357
- The comment references
toolGetTestItemsLogsByFilterbut the actual function is namedtoolGetTestItemLogsByFilter. Update the comment to match the function name.
// toolGetTestItemsLogsByFilter creates a tool to get test items logs for a specific launch.
internal/reportportal/items.go:358
- This new tool handler includes parameter parsing and API calls but has no accompanying tests. Adding unit tests for parameter handling and API request construction will help prevent regressions.
func (lr *TestItemResources) toolGetTestItemLogsByFilter() (tool mcp.Tool, handler server.ToolHandlerFunc) {
| filterEqHasStats = "true" | ||
| filterEqHasChildren = "false" | ||
| filterInType = "STEP" | ||
| defaultItemLogLevel = "TRACE" // Default log level for test item logs |
There was a problem hiding this comment.
[nitpick] The defaultItemLogLevel constant lives in launches.go but is only used in items.go. Consider relocating it closer to its usage or adding a clarifying comment about its cross-file role.
ef75f23 to
acbe5a9
Compare
acbe5a9 to
139d2b4
Compare
139d2b4 to
ede10c0
Compare
avarabyeu
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.