TestItem by ID resource template#2
Merged
Merged
Conversation
…er extraction in toolGetTestItemById
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new resource template for fetching individual test items by ID and updates the existing tool handler to use the correct parameter name.
- Registers
resourceTestItemin the server setup. - Renames comments and extracts the
test_item_idparameter intoolGetTestItemById. - Implements
resourceTestItemto parse URIs, fetch a test item, and return its JSON payload.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/reportportal/server.go | Added call to register the new resource template |
| internal/reportportal/items.go | Updated parameter extraction and added resource template logic |
Comments suppressed due to low confidence (2)
internal/reportportal/items.go:110
- [nitpick] The variable name uses
Idinstead ofID, which is inconsistent with the rest of the code (e.g.,testItemID). Consider renaming totestItemIDStrfor consistency.
testItemIdStr, found := paramValues["testItemId"]
internal/reportportal/items.go:100
- The new
resourceTestItemfunction is not covered by any tests. Consider adding unit tests for URI matching, missing parameters, and successful JSON output.
func (lr *TestItemResources) resourceTestItem() (mcp.ResourceTemplate, server.ResourceTemplateHandlerFunc) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add resource template for retrieving test items by ID; update parameter extraction in toolGetTestItemById