EPMRPP-106343 || MCP. Tool. Fix filter and tool names#29
Merged
Conversation
414f3a5 to
9852ba4
Compare
6d51141 to
8d9e052
Compare
9852ba4 to
0fcc713
Compare
be9682a to
6c96620
Compare
AmsterGet
approved these changes
Aug 1, 2025
54ce2b6 to
56681e5
Compare
6c96620 to
da2cff5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes parameter and tool naming conventions in an MCP (Model Context Protocol) tool for ReportPortal integration. The changes replace dots with hyphens in parameter names and update tool names from "list_" to "get_" prefix for consistency.
Key changes:
- Standardized parameter naming by replacing dots with hyphens (e.g., "page.size" → "page-size", "filter.cnt.name" → "filter-cnt-name")
- Updated tool names from "list_" to "get_" prefix for consistency ("list_launches" → "get_launches", "list_test_items_by_filter" → "get_test_items_by_filter")
- Updated corresponding test cases and analytics references to match new naming
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/reportportal/utils.go | Updates pagination parameter names from dot notation to hyphen notation |
| internal/reportportal/server.go | Changes tool registration calls to use new "get_" prefixed tool names |
| internal/reportportal/launches_test.go | Updates test to use new tool name "get_launches" |
| internal/reportportal/launches.go | Renames tool method and updates all filter parameter names to use hyphens |
| internal/reportportal/items.go | Renames tool method and updates all filter parameter names to use hyphens |
| internal/reportportal/analytics_test.go | Updates test assertions to use new tool names |
| Taskfile.yaml | Removes hardcoded port mapping and uses variable for inspector command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.