5.1.0.dev-2 regressions

[Coobaha]

Hi, I've tried bs-platform@5.1.0-dev.1

and it seems that it has regression (or breaking changes)?

i've spoted two:

1. for

[@genType.import "common/components/ButtonV2"] [@react.component]
external make: (~className: string=?) => React.element = "default";

gentype generates

  readonly className?: (null | undefined | string); 

makes TS mad, correct output before was

  readonly className?: string; 

2. Another issue is with bs-reform. It has interface files, which don't match implementation with new version of bsb

[21/21] Failure:Building ~/bs-platform/lib/ninja.exe 
 src/ReForm.cmj
 Location: ~/bs-reform/lib/bs

  We've found a bug for you!
  ~/bs-reform/src/ReForm.re
  
  The implementation src/ReForm.mlast
       does not match the interface src/reForm.cmi:
       ...
       At position module Create(Config) : <here>
       Values do not match:
         [@bs...] external makeProps:
           (~onSubmit: onSubmit => unit,
           ~onSubmitFail: list((Config.fields, option(string))) => unit=?,
           ~onFormStateChange: state => unit=?,
           ~validate: values => option(string)=?,
           ~initialState: Config.state, ~schema: schema,
           ~i18n: Validation.I18n.dictionary=?, ~children: 'children,
           ~key: string=?, unit) =>
           {. "children": 'children,
             "i18n": option(Validation.I18n.dictionary),
             "initialState": Config.state,
             "onFormStateChange": option(state => unit),
             "onSubmit": onSubmit => unit,
             "onSubmitFail": option(list((Config.fields, option(string))) =>
                                    unit),
             "schema": schema, "validate": option(values => option(string))}
           = ""
       is not included in
         [@bs...] external makeProps:
           (~onSubmit: onSubmit => unit,
           ~onSubmitFail: list((Config.fields, option(string))) => unit=?,
           ~onFormStateChange: state => unit=?,
           ~validate: values => option(string)=?,
           ~initialState: Config.state, ~schema: schema,
           ~i18n: Validation.I18n.dictionary=?,
           ~children: reform => ReasonReact.reactElement, ~key: string=?,
           unit) =>
           {. "children": reform => ReasonReact.reactElement,
             "i18n": option(option(Validation.I18n.dictionary)),
             "initialState": Config.state,
             "onFormStateChange": option(option(state => unit)),
             "onSubmit": onSubmit => unit,
             "onSubmitFail": option(option(list((Config.fields,
                                                option(string))) =>
                                           unit)),
             "schema": schema,
             "validate": option(option(values => option(string)))}
           = ""
       File "~/bs-reform/src/ReForm.re", line 95, characters 4-19:
         Actual declaration
  

ReForm.rei part:

 [@react.component]
    let make:
      (
        ~onSubmit: onSubmit => unit,
        ~onSubmitFail: list((Config.fields, option(string))) => unit=?,
        ~onFormStateChange: state => unit=?,
        ~validate: values => option(string)=?,
        ~initialState: Config.state,
        ~schema: schema,
        ~i18n: Validation.I18n.dictionary=?,
        ~children: reform => ReasonReact.reactElement
      ) => React.element

[bobzhang]

5.1.0.dev.1 is a mistake, can you try 5.1.0.dev.2? 发自我的iPhone

…

------------------ Original ------------------ From: Alexander Ryzhikov <notifications@github.com> Date: Sun,Jul 21,2019 3:34 PM To: BuckleScript/bucklescript <bucklescript@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [BuckleScript/bucklescript] 5.1.0.dev-1 regressions (#3695) Hi, I've tried bs-platform@5.1.0-dev.1 and it seems that it has regression (or breaking changes)? i've spoted two: for [@genType.import "common/components/ButtonV2"] [@react.component] external make: (~className: string=?) => React.element = "default"; gentype generates readonly className?: (null | undefined | string); makes TS mad, correct output before was readonly className?: string; Another issue is with bs-reform. It has interface files, which don't match implementation with new version of bsb [21/21] Failure:Building ~/bs-platform/lib/ninja.exe src/ReForm.cmj Location: ~/bs-reform/lib/bs We've found a bug for you! ~/bs-reform/src/ReForm.re The implementation src/ReForm.mlast does not match the interface src/reForm.cmi: ... At position module Create(Config) : <here> Values do not match: [@bs...] external makeProps: (~onSubmit: onSubmit => unit, ~onSubmitFail: list((Config.fields, option(string))) => unit=?, ~onFormStateChange: state => unit=?, ~validate: values => option(string)=?, ~initialState: Config.state, ~schema: schema, ~i18n: Validation.I18n.dictionary=?, ~children: 'children, ~key: string=?, unit) => {. "children": 'children, "i18n": option(Validation.I18n.dictionary), "initialState": Config.state, "onFormStateChange": option(state => unit), "onSubmit": onSubmit => unit, "onSubmitFail": option(list((Config.fields, option(string))) => unit), "schema": schema, "validate": option(values => option(string))} = "" is not included in [@bs...] external makeProps: (~onSubmit: onSubmit => unit, ~onSubmitFail: list((Config.fields, option(string))) => unit=?, ~onFormStateChange: state => unit=?, ~validate: values => option(string)=?, ~initialState: Config.state, ~schema: schema, ~i18n: Validation.I18n.dictionary=?, ~children: reform => ReasonReact.reactElement, ~key: string=?, unit) => {. "children": reform => ReasonReact.reactElement, "i18n": option(option(Validation.I18n.dictionary)), "initialState": Config.state, "onFormStateChange": option(option(state => unit)), "onSubmit": onSubmit => unit, "onSubmitFail": option(option(list((Config.fields, option(string))) => unit)), "schema": schema, "validate": option(option(values => option(string)))} = "" File "~/bs-reform/src/ReForm.re", line 95, characters 4-19: Actual declaration ReForm.rei part: [@react.component] let make: ( ~onSubmit: onSubmit => unit, ~onSubmitFail: list((Config.fields, option(string))) => unit=?, ~onFormStateChange: state => unit=?, ~validate: values => option(string)=?, ~initialState: Config.state, ~schema: schema, ~i18n: Validation.I18n.dictionary=?, ~children: reform => ReasonReact.reactElement ) => React.element — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Coobaha]

@bobzhang
I haven't noticed any difference, same errors

bs-platform@5.1.0-dev.2:
  version "5.1.0-dev.2"
  resolved "https://registry.yarnpkg.com/bs-platform/-/bs-platform-5.1.0-dev.2.tgz#854489d6c873361093e0430b19bd8ca4cf895cc8"
  integrity sha512-jwhVbuHu6JOK8kW3fbxyf52lY4PnsLF50ORYAvl5nuA1hI+0NrrUbulM7P2Hj/IHBF50x0JwZdiot9463a/vhw==

[bobzhang]

cc @cristianoc for item 1
cc @rickyvetter for item 2, I did not touch ppx recently, this may be relevant to recent fix for 4.06 #3653

[cristianoc]

Looks like the change to ppx is relevant for item 1 too. Can’t remember whether the representation of the type for optional args in the AST has changed between 4.02 and 4.06. Looks like the generated code has an option too much. @rickyvetter