Skip to content

Add dune build for editor integration. #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2022
Merged

Conversation

cristianoc
Copy link
Collaborator

This is one way to get standard ocaml editor integration work out of the box in vscode.
At dev time one would do dune build to set up the necessary files for the editor. And repeat on file changes.

Notice this does not replace the ordinary build, which does much more than build bsc.exe.

This is one way to get standard ocaml editor integration work out of the box.
At dev time one would do `dune build` to set up the necessary files for the editor. And repeat on file changes.

Notice this does not replace the ordinary build, which does much more than build bsc.exe.
@bobzhang
Copy link
Member

bobzhang commented May 5, 2022

This looks good to me since it does not interrupt existing workflow

@cristianoc
Copy link
Collaborator Author

cristianoc commented May 6, 2022

TODO: Update build instructions:

  • works on any compiler, no need for 4.06.1+rescript.
  • need to do git submodule init and git submodule update if not done before
  • need to do npm install and ./scripts/ninja.js config and ./scripts/ninja.js build
  • Only then you can do dune build, and it's only for editor integration does not replace the normal build.
  • Probably also remove mentions of buildocaml.js, mostly it would confuse people.

@ryyppy
Copy link
Member

ryyppy commented May 6, 2022

  • Since it requires M1 users to have a built node binary for arm64, we should tell users to use node@16 (could be node 16 or above, but spares us a lot of troubleshooting when we are all on the same version)

@ryyppy
Copy link
Member

ryyppy commented May 6, 2022

@cristianoc pushed some changes to the CONTRIBUTING and ninja script to make things clearer

@cristianoc cristianoc merged commit f5a2dfe into master May 7, 2022
@cristianoc cristianoc deleted the dune-build-for-devtime branch May 7, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants