Bin clean up #6401
Bin clean up #6401
Conversation
| @@ -20,23 +20,24 @@ var LAST_FIRED_EVENT = 0; | |||
| /** | |||
| * @type {[string,string][]} | |||
| */ | |||
| var reasons_to_rebuild = [["proj", "started"]]; | |||
| var reasonsToRebuild = [["proj", "started"]]; | |||
There was a problem hiding this comment.
Use camel case as a conventional style in the JS ecosystem.
|
|
||
| var LAST_SUCCESS_BUILD_STAMP = 0; | ||
| var cwd = process.cwd(); | ||
| var lockFileName = path.join(cwd, ".bsb.lock"); | ||
| process.env.BSB_PROJECT_ROOT = cwd; | ||
| // console.log('BSB_PROJECT_ROOT:', process.env.BSB_PROJECT_ROOT) |
| var error_is_tty = process.stderr.isTTY; | ||
| var std_is_tty = process.stdout.isTTY; |
There was a problem hiding this comment.
Moved to the top, so they become available in the notifyClients function. There used to be an error.
There was a problem hiding this comment.
Should these not also be changed to camel case if we're trying to make things in one style? I don't mind either way, but asking just in case.
|
|
||
| // If the project uses gentype and uses custom file extension | ||
| // via generatedFileExtension, ignore them in watch mode | ||
| var bsConfigFile = path.join(cwd, bsconfig); | ||
| var genTypeFileExtension = undefined; | ||
|
|
||
| var genTypeFileExtension = ".gen.tsx"; |
There was a problem hiding this comment.
Prefilled the default value, so we do one check less in the checkIsRebuildReason function (previously valid_event)
| /** | ||
| * @returns {string} | ||
| */ | ||
| function getDateAsString() { |
| * @param {boolean} withWebSocket | ||
| */ | ||
| function in_watch_mode(useWebSocket) { | ||
| if (useWebSocket) { | ||
| function startWatchMode(withWebSocket) { |
There was a problem hiding this comment.
Not the best name, but better than before
| if (code !== 0) { | ||
| console.log(log); |
There was a problem hiding this comment.
It might make sense to display build time even when it failed, but I've decided to keep it as it is.
| } else { | ||
| console.log(">>>> Finish compiling(exit: " + code + ")"); | ||
| } | ||
| console.log(log, Math.floor(updateFinishTime() / 1e6), "mseconds"); |
There was a problem hiding this comment.
Also, I fixed the build time display for non-TTY mode.
| if (code === 0) { | ||
| LAST_SUCCESS_BUILD_STAMP = +new Date(); | ||
| LAST_SUCCESS_BUILD_STAMP = Date.now(); |
There was a problem hiding this comment.
Date.now() is 15% faster than +new Date(). A microptimisation, but still 😊
| LAST_FIRED_EVENT = event_time; | ||
| reasons_to_rebuild.push([event, reason]); | ||
| LAST_FIRED_EVENT = eventTime; | ||
| reasonsToRebuild.push([event, reason || ""]); |
There was a problem hiding this comment.
I've fixed the type, so the fallback became needed.
|
Next, I want to work on fixing the watch mode after the |
|
Sweet. Are there any specific node requirements for this? CC @zth |
There shouldn't be. But I'll test with NodeJs 10 just in case. |
| var error_is_tty = process.stderr.isTTY; | ||
| var std_is_tty = process.stdout.isTTY; |
There was a problem hiding this comment.
Should these not also be changed to camel case if we're trying to make things in one style? I don't mind either way, but asking just in case.
|
I've tested with node V10. It works.
I couldn't come up with a good name for them, so decided to leave them for the next PR 😅 |
I want to do a few fixes in the file, so I've decided to start with a lil clean up.
++ Display build time in the non-TTY mode