-
Notifications
You must be signed in to change notification settings - Fork 469
Compile runtime with rewatch and add rewatch tests to the compiler repo #7422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jfrolich
wants to merge
44
commits into
master
Choose a base branch
from
rewatch-runtime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
43b1196
change config
jfrolich 4a0de83
still need -make-runtime
jfrolich f68c527
add make lib-rewatch
jfrolich 4102492
update rewatch
jfrolich dbcedd2
test rewatch in Makefile
jfrolich c723cb0
test
jfrolich 6c756ab
add install state
jfrolich 373417d
upstream new version of rewatch
jfrolich 4706c4b
make it work!
jfrolich 6a8d721
make rewatch default for building the runtime
jfrolich 7be0619
run rewatch tests
jfrolich 73105c7
see error
jfrolich 5a1a786
install packages as part of the ci test suite
jfrolich ed60167
cat the changes
jfrolich c5e39b1
empty commit
jfrolich f6319c8
immutable install
jfrolich 46b14c8
remove install state
jfrolich f2c7988
install state ignore
jfrolich 1484c3f
run on mac os due to subtle diffs
jfrolich 59edb1a
fix
jfrolich e77b6a7
use ci version of rescript
jfrolich c32740c
fix diff
jfrolich df352ea
trigger
jfrolich b597700
fix
jfrolich e7af0b9
show rescript version
jfrolich e1c36d0
update snapshots
jfrolich 88e8b61
end to end tests
jfrolich 3ff6cb0
fix
jfrolich 8a397d1
fix
jfrolich 8925187
fix
jfrolich 1fcde23
propagate bsc path
jfrolich 69d0089
fix
jfrolich d191e3b
empty commit
jfrolich e05a6a5
don't run unit tests if we don't build a new rewatch binary
jfrolich 175cffd
other instance
jfrolich 89316aa
empty commit
jfrolich 391f785
find correct bsc
jfrolich aced9b1
if the lockfile is deleted, stop running the watcher
jfrolich 5d0e318
fix lock tests
jfrolich 408e082
More informative test
jfrolich 78f16af
fix watch
jfrolich 71b39d4
make tests work correctly
jfrolich c772dd9
fix
jfrolich d3809a9
upstream changes
jfrolich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
[alias] | ||
build-m1-release = "RUSTFLAGS=\"-C target-cpu=apple-m1\" cargo build --release" | ||
build-docs = "cargo doc --no-deps --document-private-items --target-dir ./docs" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
/target | ||
.DS_Store | ||
/docs |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a real integration test of both rewatch + bsc packaged up in the test repo, to make sure it works end to end