more ocaml less typescript #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardoRFS
pushed a commit
to EduardoRFS/bucklescript
that referenced
this pull request
Apr 5, 2021
kevinbarabash
pushed a commit
to kevinbarabash/rescript-compiler
that referenced
this pull request
Dec 24, 2021
The previous approach put the scanner in "Template" mode when the parser was going to parse template literals. This resulted in some very awkward code; upon scanning a token there was logic checking whether we were in "Template" mode. Every non-template literal token would pay for this extra branch… The new parsing strategy works differently: when the parser needs to parse template literals, it just asks the scanner immediately for a template literal token. This is both more performant an easier to reason about. Template literals are a different language, it makes sense to split this into a separate scanning function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.