This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Emit an error when a @string or @int attribute is used in V4. #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
commented
Oct 12, 2022
cli/reactjs_jsx_v4.ml
Outdated
| let transformStructureItem ~config mapper item = | ||
| check_string_int_attribute_iter.structure_item check_string_int_attribute_iter |
There was a problem hiding this comment.
This currently fires anywhere.
I guess it can be scoped to fire only under @react.component.
There was a problem hiding this comment.
Ah ok, hadn't seen that before I approved, sorry.
Yes, should be scoped under @react.component.
cknitt
approved these changes
Oct 12, 2022
cknitt
approved these changes
Oct 12, 2022
cknitt
approved these changes
Oct 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rescript-lang/rescript#5724