Skip to content

fix(errorBoundary): fallback to children to propagate different errors #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

Rendez
Copy link
Contributor

@Rendez Rendez commented Mar 25, 2020

Fixes #101 and #102

@Rendez Rendez changed the title fix(errorBoundaryBubbling): re-render children to not shallow differe… fix(errorBoundaryBubbling): re-render children to not swallow different errors Mar 25, 2020
@Rendez Rendez requested a review from SevInf March 25, 2020 12:03
@Rendez Rendez force-pushed the fix/error-boundary-bubbling branch from 5bc10a7 to 5ec6fde Compare March 25, 2020 13:27
@Rendez Rendez changed the title fix(errorBoundaryBubbling): re-render children to not swallow different errors fix(errorBoundary): fallback to children to propagate different errors Mar 25, 2020
@Rendez Rendez merged commit 78eb990 into master Mar 26, 2020
@Rendez Rendez deleted the fix/error-boundary-bubbling branch March 26, 2020 09:50
Rendez pushed a commit that referenced this pull request Mar 26, 2020
## [1.1.2](v1.1.1...v1.1.2) (2020-03-26)

### Bug Fixes

* **errorBoundary:** fallback to children to propagate different errors ([#105](#105)) ([78eb990](78eb990))
@Rendez
Copy link
Contributor Author

Rendez commented Mar 26, 2020

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error boundary catches errors of child components
2 participants