Skip to content

DNL Mikebauer/multi goal events #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mikebauer
Copy link
Contributor

Description of change

Guide to reproduce test results.

Checklist:

  • I have self-reviewed this change.
  • I have tested this change.
  • This change is covered by tests that are already landed, or in this PR.

@@ -343,7 +343,7 @@ async def compute_batch_metrics(
if "?" in basename:
continue

for ii in range(len(events) - 1):
for ii in range(len(events)):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curse ye off by one error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants