Skip to content

add ProcessUpdateEvent trigger to controll whether sent the event to the recivers when the event is update #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add ProcessUpdateEvent trigger to controll whether sent the event to the recivers when the event is update #126

wants to merge 1 commit into from

Conversation

wuzhuoquan
Copy link

if an event occur many times, It will only update the event fields like count and lastTimestamp.
By default kubernetes-event-exporter will ignore the eventUpdate and will not sent to the recivers.
If you Don't want to miss every event,you can use trigger processUpdateEvent to controll whether sent the event to the recivers.

@jmos5156

This comment was marked as spam.

@mustafaakin
Copy link

I have conflicting views on this. While agree this is needed, it's not applicable for all sinks, that are append only and would result in huge duplicates because of image cannot be pulled x1000 times. Instead it should be configured sink level

@jmos5156

This comment was marked as spam.

@wuzhuoquan
Copy link
Author

I have conflicting views on this. While agree this is needed, it's not applicable for all sinks, that are append only and would result in huge duplicates because of image cannot be pulled x1000 times. Instead it should be configured sink level

So this PR only set the trigger processUpdateEvent to controller whether sent all events to the recivers. By default is false, means will not sent the update event to sinks, but sometimes the user want to sent all event to sinks, then they can set it to true.

This PR only provide a option for the user to make it possible.

@jmos5156

This comment was marked as spam.

@t3mi t3mi mentioned this pull request Sep 29, 2023
@jmos5156

This comment was marked as spam.

@mustafaakin
Copy link

Problem with this contribution is that configuration should be local to each sink. It does not matter that default is false. If it's enabled to true, it sends changes to all sinks regardless of it makes sense or not. I want ability to send regular messages to one sink (Opsgenie), and all updates to another (Kafka)

Additionally, the sinks need to be aware of ID generation so the sinks can update the data instead of growing the underlying storage.

Therefore, unless those changes are made, I can't merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants