Skip to content

Set minimum System.Text.Json version to 5.0.1#1923

Merged
alexeyzimarev merged 1 commit intorestsharp:devfrom
LauraArmitage:fix-vulnerability
Sep 20, 2022
Merged

Set minimum System.Text.Json version to 5.0.1#1923
alexeyzimarev merged 1 commit intorestsharp:devfrom
LauraArmitage:fix-vulnerability

Conversation

@LauraArmitage
Copy link
Contributor

Description

Fix #1899

@alexeyzimarev
Copy link
Member

Thanks for the fix. One question: why have you removed the open upper version constraint?

@LauraArmitage
Copy link
Contributor Author

Sorry, I've not done this right - I was just trying to merge this into my fork. I've not tested this yet
From this doc I interpret that [5.0,) sets an inclusive minimum only and this would be the same but with a higher minimum version.

@LauraArmitage LauraArmitage marked this pull request as draft September 13, 2022 15:30
@alexeyzimarev
Copy link
Member

I think it could be [5.0.1,)

@alexeyzimarev
Copy link
Member

Could also be (5.0,). Yes, I think your current implementation is correct, I didn't read the docs correctly.

@LauraArmitage
Copy link
Contributor Author

Thanks, I'll mark this as ready for review once I've tested

@alexeyzimarev alexeyzimarev marked this pull request as ready for review September 20, 2022 07:36
@alexeyzimarev alexeyzimarev merged commit dc2e12d into restsharp:dev Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update System.Text.Json to remove a critical vulnerability

2 participants