Universal Apps compatibility #754
Conversation
| @@ -9,7 +16,7 @@ internal static class OAuthExtensions | |||
| public static string ToRequestValue(this OAuthSignatureMethod signatureMethod) | |||
| { | |||
| string value = signatureMethod.ToString() | |||
| .ToUpper(); | |||
| .ToUpper(); | |||
There was a problem hiding this comment.
please revert this formatting change
|
so there are a lot of re-implemented functions. i'm not sure why you had to do this but there has to be a better way. i am not yet running a windows 10 environment so support for those frameworks that depend on that will have to wait until i have one set up. i'm going to close this as i'll get this support in personally since it's a potentially damaging change to the library. there is an open issue asking for this support and it will get done in the future. |
|
As you wish @hallem, it's your call. In most cases I've just added extensions methods that do the same thing they were doing before for all targets except UWP and slightly different implementation for UWP. This was necessary because the code won't even compile otherwise. In general I don't feel really happy about closing branch without even waiting for replies or to the time when you get working environment and verify properly. |
|
One more small note. It seems that you can actually build UWP code on Windows 7/8.1 |
|
Dixon, I understand. I like to keep thing clean and since this is a impactive change and I'm not entirely happy with the way you coded the extensions I'd like time to take a look myself. I can always reopen this and it's tagged for me to look at later. Closing it just hides it from view when other people come in. Thanks for the link I'll take a look at it as soon as I have some spare time. |
|
@hallem Any news on this topic? |
|
@MrZoidberg no not as of yet. I had to step away from the project for a bit and should have some time to get back into it now. |
Tried to address #745 . It is my first attempt to write PCL code, so please review carefully.