add support for aarch64-pc-windows-msvc #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI fell over: |
|
Rebased and updated commits now that |
|
Ping? |
retep998
reviewed
Sep 28, 2018
retep998
reviewed
Sep 28, 2018
|
Patch updated with the two small comments addressed. If a 0.3.7 release could be made with these changes, that would be much appreciated! |
|
Ping? |
1 similar comment
|
Ping? |
|
Pong? |
Comments addressed, green CI, I'm not sure what else to do here. AFAICT, the ball is in your court to either merge it or indicate what else you want done here. |
retep998
requested changes
Oct 16, 2018
Most of the additions are where `_WIN64` was being checked, in which case we add a case next to the `target_arch = "x86_64"` checks. Other headers, particularly winnt.h, require custom AArch64-specific types.
This style is shorter, and corresponds more closer to the headers depending on _WIN64 and the like.
|
Blank line removed, as requested. Please review. |
retep998
approved these changes
Oct 27, 2018
|
Thank you! |
|
winapi 0.3.7 is now out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of this is just finding places where we were conditionalizing on
target_arch = "x86_64"and using atarget_pointer_widthtest instead. The real interesting parts are inwinnt.rs.I'm not sure of a good way to test this. Everything builds OK on
x86_64-pc-windows-msvc, so I haven't broken anything. Unfortunately, theaarch64-pc-windows-msvctarget is in a bit of a rough state (see rust-lang/rust#53864), and I can't buildlibstdfor that target locally. I did try making theaarch64definitions compile onx86_64(and vice versa) inwinnt.rs, and building with that change seemed to be OK.