Another take on avoiding garbage in classpath lookups #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
ticket/11664-alloc
branch
2 times, most recently
from
996bef3 to
7d3a317
Compare
Closed
Escape dollar signs for variables in doc comments
Reduce allocations in the backend
This commit reverts part of the scala#8322 I recently changed to using the last entry from getResources to avoid parent classloader delegation, but this leads to unwanted results if the plugin classpath itself contains multiple `scalac-plugin.xml` resources and wants the compiler to choose the first. I have _not_ reverted the other change in scala#8322 which overrides `getResource` to avoid parent delegation for `scalac-plugin.xml`. I have documented the `findPluginClassLoader` extension point with instructions to do the same.
…tweak Use the first scalac-plugin.xml from the plugin classpath
retronym
force-pushed
the
ticket/11664-alloc
branch
from
2ba4f60 to
42b055a
Compare
- Avoid repeated conversion between package dotted names ("com.foo")
and relative paths ("com/foo/") by threading a `PackageName`
instance through the aggregate classpath lookup which caches
the path name.
- Avoid creating result buffers inside of each element of the
aggregate classpath by introducing a callback based API that
lets `AggregateClasspath` use a single buffer.
retronym
force-pushed
the
ticket/11664-alloc
branch
from
42b055a to
22edf28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.