-
-
Notifications
You must be signed in to change notification settings - Fork 71
support npm v9 #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support npm v9 #157
Conversation
| echo '::endgroup::' | ||
|
|
||
| if [ ! -f "$(npm bin)/eslint" ]; then | ||
| npx --offline eslint --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npx will print error below if no cache is available. Should we suppress the output?
$ npx --offline eslint --version >/dev/null
npm ERR! code ENOTCACHED
npm ERR! request to https://registry.npmjs.org/eslint failed: cache mode is 'only-if-cached' but no cached response is available.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/yshrsmz/.npm/_logs/2023-01-20T12_15_39_019Z-debug-0.log
|
@haya14busa @shogo82148 Hi, sorry to bother you, but could you possibly take a look? |
Lolly1150
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Any update on this? |
|
ubuntu-latest now has node 18 and npm 9 as a default, please merge and release this fix ASAP |
shogo82148
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🚀 [bumpr] Bumped! New version:v1.18.0 Changes:v1.17.0...v1.18.0 |
|
Hi, @yshrsmz! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
1 similar comment
|
Hi, @yshrsmz! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |

fix: #152
According to the document,
npx --offline foouses locally-cached binary and fails if there's no cached binary.I'm going to create a PR for action-stylelint once this PR gets merged