Skip to content

Conversation

@yshrsmz
Copy link
Member

@yshrsmz yshrsmz commented Jan 20, 2023

fix: #152

According to the document, npx --offline foo uses locally-cached binary and fails if there's no cached binary.

I'm going to create a PR for action-stylelint once this PR gets merged

echo '::endgroup::'

if [ ! -f "$(npm bin)/eslint" ]; then
npx --offline eslint --version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npx will print error below if no cache is available. Should we suppress the output?

$ npx --offline eslint --version >/dev/null
npm ERR! code ENOTCACHED
npm ERR! request to https://registry.npmjs.org/eslint failed: cache mode is 'only-if-cached' but no cached response is available.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/yshrsmz/.npm/_logs/2023-01-20T12_15_39_019Z-debug-0.log

@yshrsmz
Copy link
Member Author

yshrsmz commented Feb 4, 2023

@haya14busa @shogo82148 Hi, sorry to bother you, but could you possibly take a look?

Copy link

@Lolly1150 Lolly1150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yykamei
Copy link

yykamei commented Feb 20, 2023

Hi, I need this pull request to be merged 🙏
I came across an error like this, and I guess, this could be solved with the PR.

Screen Shot 2023-02-20 at 9 15 04

@davideme
Copy link

Any update on this?

@michadvorak-cen38289
Copy link

ubuntu-latest now has node 18 and npm 9 as a default, please merge and release this fix ASAP

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit 5221553 into reviewdog:master Feb 22, 2023
@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v1.18.0 Changes:v1.17.0...v1.18.0

@review-dog
Copy link
Member

Hi, @yshrsmz! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

1 similar comment
@review-dog
Copy link
Member

Hi, @yshrsmz! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

@yshrsmz yshrsmz deleted the npm-v9 branch February 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support npm v9

7 participants