Skip to content

Remove default value for setErrorHandler #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Dec 3, 2021

setErrorHandler() looks weird and IDEs will flag setErrorHandler(null) as passing an unnecessary parameter.

We should likely also make it void and introduce a separate getErrorHandler().

setErrorHandler() looks weird and IDEs will flag setErrorHandler(null) as passing an unnecessary parameter.
@kelunik kelunik added this to the 0.2.0 milestone Dec 10, 2021
@kelunik kelunik merged commit 6b20b0f into main Jan 10, 2022
@kelunik kelunik deleted the set-error-handler branch January 10, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants