Skip to content

Throw UnhandledThrowable if event loop stops due to an exception #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 11, 2022
Merged

Throw UnhandledThrowable if event loop stops due to an exception #32

merged 5 commits into from
Jan 11, 2022

Conversation

kelunik
Copy link
Member

@kelunik kelunik commented Dec 9, 2021

This is a follow-up on #31.

It allows differentiating between Suspension erroring and a Suspension being interrupted by an unhandled event loop error.

@kelunik kelunik force-pushed the unhandled-exceptions branch from 1cdaab3 to c34acb8 Compare December 9, 2021 21:09
kelunik
kelunik commented Dec 9, 2021
View reviewed changes
@kelunik kelunik mentioned this pull request Dec 10, 2021
Merged
@kelunik kelunik added this to the 0.2.0 milestone Dec 10, 2021
trowski
trowski approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@trowski trowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can get some more metadata that would be great, but overall this is a nice change.

@kelunik kelunik force-pushed the unhandled-exceptions branch from f04c099 to dd6db27 Compare January 10, 2022 20:29
@kelunik kelunik force-pushed the unhandled-exceptions branch from 08529b8 to 23663fa Compare January 11, 2022 19:27
@kelunik kelunik changed the title Throw UnhandledException if event loop stops due to an exception Throw UnhandledThrowable if event loop stops due to an exception Jan 11, 2022
@kelunik kelunik merged commit 3778614 into main Jan 11, 2022
@kelunik kelunik deleted the unhandled-exceptions branch January 11, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@trowski trowski trowski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kelunik @WyriHaximus @trowski