-
Notifications
You must be signed in to change notification settings - Fork 31
Cache suspensions #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createSuspension
I think is a fine name. Decorating drivers may still return a new object implementing Suspension
to implement some fiber-locals, etc.
|
Yes, I suppose you're right. My initial thinking was |
|
It does return the same instance, per fiber. It's similar to a |
yea, but I'm talking generally ( as between different fibers ), maybe |
@trowski @WyriHaximus Renamed and added a documentation comment that the driver must always return the same instance for each fiber. |
+1 for keeping the old method and deprecating it during 0.2.x. |
I've added |
* main: Also avoid re-creating callback fiber for throwing microtasks Avoid re-creating callback fiber on exceptions Remove fiber switches on callback fiber creation
Not sure whether this is useful. If we go that route, we should rename
createSuspension
intogetSuspension
.