-
Notifications
You must be signed in to change notification settings - Fork 31
Implement fiber local storage #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kelunik This looks nice now, I think I prefer it over the changes in my branch. Can we add a template type to |
trowski
reviewed
Jan 13, 2022
@kelunik Can you add a (simple) example on how to use this to the |
kelunik
commented
Jan 13, 2022
@WyriHaximus I've added two examples. |
trowski
approved these changes
Jan 13, 2022
WyriHaximus
reviewed
Jan 14, 2022
It's good to see how merging #41 makes some tests here fail. 😄 |
WyriHaximus
approved these changes
Jan 14, 2022
Added template types too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've previously implemented this in https://github.com/kelunik/fiber-local, but I think it's important to clear the storage if we reuse fibers.