oran: add new api package for o2ims api #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
sebrandon1
previously approved these changes
Apr 28, 2025
klaskosk
force-pushed
the
oran-api
branch
2 times, most recently
from
3bf5c56 to
5d00508
Compare
The current oran package uses the Kubernetes API to interact with the O-RAN resources. However, an important aspect of O-RAN is the ability to use the O2IMS API to perform basic CRUD operations on these resources. To allow using both APIs, starting with just the ProvisioningRequest resource, this PR includes a number of changes: * OpenAPI codegen tool using the new tool feature in go 1.24. This allows for including the tool dependencies separate from our actual dependencies. * Including the openapi.yaml files from openshift-kni/oran-o2ims and using them to automatically generate clients. * A client builder and a specific ProvisioningClient to interact more broadly with the O2IMS API and the specific API for provisioning. * Implementation of runtimeclient.Client for the ProvisioningClient, allowing the existing ProvisioningRequestBuilder to (mostly) transparently use the O2IMS API. * Unit tests for all the ProvisioningClient methods using a mock of the generated client. * Separate depguard rules for the oran/api package that allow using the oapi-codegen runtime.
sebrandon1
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current oran package uses the Kubernetes API to interact with the O-RAN resources. However, an important aspect of O-RAN is the ability to use the O2IMS API to perform basic CRUD operations on these resources. To allow using both APIs, starting with just the ProvisioningRequest resource, this PR includes a number of changes: