Skip to content

Conversation

cdvultur
Copy link
Collaborator

@cdvultur cdvultur commented Jun 13, 2025

The new release-2.4 of KMM will drop the preflightvalidationocp crd.

The tests will be moved to the u/s crd: preflightvalidation

This PR is a precursor of the crd removal and assures that there are no breakages.

klaskosk
klaskosk previously approved these changes Jun 13, 2025
Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits and a warning about the Exists method, but overall looks good and we'll end up resolving the warning with the common methods next release anyway

@klaskosk
Copy link
Collaborator

Integration test failure is something I need to look at and stabilize so we can ignore it for now

@cdvultur
Copy link
Collaborator Author

Wondered why it failed, given that locally make lint worked locally.

@cdvultur cdvultur merged commit fe100c5 into rh-ecosystem-edge:main Jun 16, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants