-
Notifications
You must be signed in to change notification settings - Fork 39
PfStatus: add Pf Status Relay Operator types #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PfStatus: add Pf Status Relay Operator types #1069
Conversation
6203788
to
7616314
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried experimenting with using the GitHub MCP and Cursor to do a pull request review. The tone is a little wrong (I wouldn't exactly call an incorrect log message a major issue), but I deleted any comments that weren't applicable
Overall the PR looks good, it's mostly some minor cleaning up of names left
94e5c69
to
fba461c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! One small comment about the types in Pull
, otherwise lgtm
fba461c
to
f36133f
Compare
Adding the pf status relay operator types to eco-goinfra.