Skip to content

Conversation

gkopels
Copy link
Contributor

@gkopels gkopels commented Jul 2, 2025

Adding the pf status relay operator types to eco-goinfra.

@gkopels gkopels force-pushed the add-pf-status-relay-operator branch 10 times, most recently from 6203788 to 7616314 Compare July 3, 2025 13:31
@gkopels gkopels changed the title WIP: add pfstatusrrelay types PfStatus: add Pf Status Relay Operator types Jul 3, 2025
Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried experimenting with using the GitHub MCP and Cursor to do a pull request review. The tone is a little wrong (I wouldn't exactly call an incorrect log message a major issue), but I deleted any comments that weren't applicable

Overall the PR looks good, it's mostly some minor cleaning up of names left

@gkopels gkopels force-pushed the add-pf-status-relay-operator branch 6 times, most recently from 94e5c69 to fba461c Compare July 6, 2025 18:07
Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! One small comment about the types in Pull, otherwise lgtm

@gkopels gkopels force-pushed the add-pf-status-relay-operator branch from fba461c to f36133f Compare July 8, 2025 10:35
@trewest trewest merged commit a654954 into rh-ecosystem-edge:main Jul 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants