integration: add pod tests #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Mar 2, 2025
Depends-on: rh-ecosystem-edge#947 Currently, the pod package always uses the SPDY executor for executing commands. However, in Kubernetes 1.30, the websocket executor graduated to beta and is now enabled by default. This PR uses the FallbackExecutor to default to the websocket executor and only fallback to the SPDY executor if the websocket executor is unavailable. Notably, the websocket executor should fix the issue of the stdout being truncated unexpectedly.
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Mar 2, 2025
Depends-on: rh-ecosystem-edge#947 Currently, the pod package always uses the SPDY executor for executing commands. However, in Kubernetes 1.30, the websocket executor graduated to beta and is now enabled by default. This PR uses the FallbackExecutor to default to the websocket executor and only fallback to the SPDY executor if the websocket executor is unavailable. Notably, the websocket executor should fix the issue of the stdout being truncated unexpectedly.
sebrandon1
previously approved these changes
Mar 3, 2025
klaskosk
force-pushed
the
pod-integration-exec
branch
2 times, most recently
from
7d975ae to
63bf68e
Compare
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Mar 5, 2025
Depends-on: rh-ecosystem-edge#947 Currently, the pod package always uses the SPDY executor for executing commands. However, in Kubernetes 1.30, the websocket executor graduated to beta and is now enabled by default. This PR uses the FallbackExecutor to default to the websocket executor and only fallback to the SPDY executor if the websocket executor is unavailable. Notably, the websocket executor should fix the issue of the stdout being truncated unexpectedly.
sebrandon1
reviewed
Mar 20, 2025
sebrandon1
reviewed
Mar 20, 2025
klaskosk
force-pushed
the
pod-integration-exec
branch
2 times, most recently
from
8fbb1fc to
075c652
Compare
klaskosk
force-pushed
the
pod-integration-exec
branch
from
075c652 to
112ba08
Compare
* Added Create and Delete integration tests for the pod resource. * Added an ExecCommand test too for the pod resource. Since we do not have any unit tests for this function (and rh-ecosystem-edge#602 to add them is a draft), it will be good to have some assurance it is working. The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.
klaskosk
force-pushed
the
pod-integration-exec
branch
from
112ba08 to
5ad1d57
Compare
sebrandon1
approved these changes
May 29, 2025
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Jul 8, 2025
Depends-on: rh-ecosystem-edge#947 Currently, the pod package always uses the SPDY executor for executing commands. However, in Kubernetes 1.30, the websocket executor graduated to beta and is now enabled by default. This PR uses the FallbackExecutor to default to the websocket executor and only fallback to the SPDY executor if the websocket executor is unavailable. Notably, the websocket executor should fix the issue of the stdout being truncated unexpectedly.
klaskosk
added a commit
to klaskosk/eco-goinfra
that referenced
this pull request
Aug 26, 2025
Depends-on: rh-ecosystem-edge#947 Currently, the pod package always uses the SPDY executor for executing commands. However, in Kubernetes 1.30, the websocket executor graduated to beta and is now enabled by default. This PR uses the FallbackExecutor to default to the websocket executor and only fallback to the SPDY executor if the websocket executor is unavailable. Notably, the websocket executor should fix the issue of the stdout being truncated unexpectedly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter point is also motivated by a desire to use a FallbackExecutor to enable the websocket executor for Kubernetes 1.30+ (OpenShift 4.17+). This will be a future PR, however.