Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/nmstate/nodenetworkstate.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"github.com/openshift-kni/eco-goinfra/pkg/clients"
"github.com/openshift-kni/eco-goinfra/pkg/msg"

nmstateV1alpha1 "github.com/nmstate/kubernetes-nmstate/api/v1alpha1"
nmstateV1beta1 "github.com/nmstate/kubernetes-nmstate/api/v1beta1"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
goclient "sigs.k8s.io/controller-runtime/pkg/client"
Expand All @@ -27,7 +27,7 @@ var (
// StateBuilder provides struct for the NodeNetworkState object containing connection to the cluster.
type StateBuilder struct {
// Created NodeNetworkState object on the cluster.
Object *nmstateV1alpha1.NodeNetworkState
Object *nmstateV1beta1.NodeNetworkState
// API client to interact with the cluster.
apiClient goclient.Client
// errorMsg is processed before NodeNetworkState object is created.
Expand All @@ -53,14 +53,14 @@ func (builder *StateBuilder) Exists() bool {
}

// Get returns NodeNetworkState object if found.
func (builder *StateBuilder) Get() (*nmstateV1alpha1.NodeNetworkState, error) {
func (builder *StateBuilder) Get() (*nmstateV1beta1.NodeNetworkState, error) {
if valid, err := builder.validate(); !valid {
return nil, err
}

glog.V(100).Infof("Collecting NodeNetworkState object %s", builder.Object.Name)

nodeNetworkState := &nmstateV1alpha1.NodeNetworkState{}
nodeNetworkState := &nmstateV1beta1.NodeNetworkState{}
err := builder.apiClient.Get(context.TODO(), goclient.ObjectKey{
Name: builder.Object.Name,
}, nodeNetworkState)
Expand Down Expand Up @@ -188,7 +188,7 @@ func PullNodeNetworkState(apiClient *clients.Settings, name string) (*StateBuild
return nil, fmt.Errorf("the apiClient cannot be nil")
}

err := apiClient.AttachScheme(nmstateV1alpha1.AddToScheme)
err := apiClient.AttachScheme(nmstateV1beta1.AddToScheme)
if err != nil {
glog.V(100).Infof("Failed to add nmstate v1 scheme to client schemes")

Expand All @@ -197,7 +197,7 @@ func PullNodeNetworkState(apiClient *clients.Settings, name string) (*StateBuild

stateBuilder := &StateBuilder{
apiClient: apiClient.Client,
Object: &nmstateV1alpha1.NodeNetworkState{
Object: &nmstateV1beta1.NodeNetworkState{
ObjectMeta: metav1.ObjectMeta{
Name: name,
},
Expand Down
20 changes: 10 additions & 10 deletions pkg/nmstate/nodenetworkstate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"testing"

"github.com/nmstate/kubernetes-nmstate/api/shared"
nmstateV1alpha1 "github.com/nmstate/kubernetes-nmstate/api/v1alpha1"
nmstateV1beta1 "github.com/nmstate/kubernetes-nmstate/api/v1beta1"
"github.com/openshift-kni/eco-goinfra/pkg/clients"
"github.com/stretchr/testify/assert"
"gopkg.in/yaml.v2"
Expand All @@ -14,16 +14,16 @@ import (
)

var (
nmstateV1alpha1TestSchemes = []clients.SchemeAttacher{
nmstateV1alpha1.AddToScheme,
nmstateV1beta1TestSchemes = []clients.SchemeAttacher{
nmstateV1beta1.AddToScheme,
}
sriovExistingInterface = "ensf0"
vfNumber = 10
)

func TestPullNodeNetworkState(t *testing.T) {
generateNodeNetState := func(name string) *nmstateV1alpha1.NodeNetworkState {
return &nmstateV1alpha1.NodeNetworkState{
generateNodeNetState := func(name string) *nmstateV1beta1.NodeNetworkState {
return &nmstateV1beta1.NodeNetworkState{
ObjectMeta: metav1.ObjectMeta{
Name: name,
},
Expand Down Expand Up @@ -82,7 +82,7 @@ func TestPullNodeNetworkState(t *testing.T) {
if testCase.client {
testSettings = clients.GetTestClients(clients.TestClientParams{
K8sMockObjects: runtimeObjects,
SchemeAttachers: nmstateV1alpha1TestSchemes,
SchemeAttachers: nmstateV1beta1TestSchemes,
})
}

Expand Down Expand Up @@ -276,12 +276,12 @@ func buildValidNodeNetworkStateTestBuilder(apiClient *clients.Settings) *StateBu
func buildTestClientWithDummyNodeNetworkStateObject() *clients.Settings {
return clients.GetTestClients(clients.TestClientParams{
K8sMockObjects: buildDummyNodeNetworkStateObject(),
SchemeAttachers: nmstateV1alpha1TestSchemes,
SchemeAttachers: nmstateV1beta1TestSchemes,
})
}

func buildDummyNodeNetworkStateObject() []runtime.Object {
return append([]runtime.Object{}, &nmstateV1alpha1.NodeNetworkState{
return append([]runtime.Object{}, &nmstateV1beta1.NodeNetworkState{
ObjectMeta: metav1.ObjectMeta{
Name: defaultNMStateName,
},
Expand Down Expand Up @@ -309,15 +309,15 @@ func newNodeNetworkStateBuilder(apiClient *clients.Settings, name string) *State
},
}
byteDesiredState, _ := yaml.Marshal(desiredState)
err := apiClient.AttachScheme(nmstateV1alpha1.AddToScheme)
err := apiClient.AttachScheme(nmstateV1beta1.AddToScheme)

if err != nil {
return nil
}

builder := StateBuilder{
apiClient: apiClient.Client,
Object: &nmstateV1alpha1.NodeNetworkState{
Object: &nmstateV1beta1.NodeNetworkState{
ObjectMeta: metav1.ObjectMeta{
Name: name,
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading