DeleteGraceful method for deployment added #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yprokule
requested review from
kononovn,
trewest,
achuzhoy,
cdvultur and
klaskosk
as code owners
yprokule
force-pushed
the
delete-deploy-grace
branch
from
ea6b5b2 to
1163cfd
Compare
yprokule
force-pushed
the
delete-deploy-grace
branch
from
1163cfd to
d03bb46
Compare
klaskosk
reviewed
Mar 31, 2025
pkg/deployment/deployment.go
Outdated
| return fmt.Errorf("gracePeriod must be non-negative integer") | ||
| } | ||
|
|
||
| glog.V(100).Infof("Requested DeleteGracePeriod %v seconds", gracePeriod) |
There was a problem hiding this comment.
could you please remove this log now that the other one has been updated?
yprokule
force-pushed
the
delete-deploy-grace
branch
from
d03bb46 to
9c2d1eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.