cnf network: add ethernet interface type to nmstate policy #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkopels
requested review from
kononovn,
trewest,
achuzhoy,
cdvultur and
klaskosk
as code owners
gkopels
force-pushed
the
add-nodenetworkconfigpolicy-ethernet-interface
branch
from
fbadee5 to
9b0103c
Compare
ajaggapa
reviewed
Apr 16, 2025
pkg/nmstate/policy.go
Outdated
| @@ -399,6 +399,64 @@ func (builder *PolicyBuilder) WithVlanInterfaceIP(baseInterface, ipv4Addresses, | |||
| return builder.withInterface(newInterface) | |||
| } | |||
|
|
|||
| // WithEthernetInterface adds type ethernet interface and IPs configuration to the NodeNetworkConfigurationPolicy. | |||
| func (builder *PolicyBuilder) WithEthernetInterface(interfaceName, ipv4Addresses, ipv6Addresses string) *PolicyBuilder { | |||
There was a problem hiding this comment.
Cosmetic
Since we accept only one IPv4 Address & one IPv6 Address, may be just change the vars to ipv4Address & ipv6Address
gkopels
force-pushed
the
add-nodenetworkconfigpolicy-ethernet-interface
branch
from
9b0103c to
1d3e83d
Compare
sebrandon1
approved these changes
Apr 18, 2025
klaskosk
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a ethernet interface with IP addresses to the nmstate policy