Skip to content

Incorrect visibility calculation with {force: false, offset: nonZero}  #138

@nburlett

Description

@nburlett

The scroller can incorrectly decide that an element is already visible when
specifying {force: false, offset: nonZero}. The code checks if targetY is
within the current visible portion of container, but targetY has the
offset applied already.

*------------*
| container  |
| above      |
*~ ~ ~ ~ ~ ~ * container top
|            |
| visible    |
| area       |
|            | <-| 
|            |   |
|            |   |
|            |   | skips scrolling if elm
*~ ~ ~ ~ ~ ~ *   | is within this area
| *-------*  |   | 
| | elm   |  |   |
| *-------*  |   |
|            | <-|
| container  |
| below      |
*------------*

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions