refactor: convert new TS files to async/await #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors recently converted TypeScript files to use modern async/await syntax instead of promise .then() chains, improving code readability and maintainability. The changes are purely structural with no functional modifications.
Key Changes:
- Converted promise chains to async/await pattern across multiple rippled service files
- Improved type annotations and simplified logic in transaction and ledger summary utilities
- Modernized export syntax to use inline re-exports
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/rippled/transactions.ts | Converted getTransaction to async/await with try/catch error handling |
| src/rippled/quorum.ts | Converted getQuorum to async/await with try/catch error handling |
| src/rippled/nUNL.ts | Converted getNegativeUNL to async/await with try/catch error handling |
| src/rippled/lib/txSummary/index.ts | Added explicit type annotation and simplified conditional logic in summarizeTransaction |
| src/rippled/lib/summarizeLedger.ts | Refactored to use functional map/reduce pattern and added type annotation for parameter |
| src/rippled/lib/rippled.ts | Converted 20+ functions from promise chains to async/await pattern |
| src/rippled/ledgers.ts | Converted getLedger to async/await and added return type annotation |
| src/rippled/index.ts | Simplified exports using inline re-export syntax |
| src/rippled/accountTransactions.ts | Converted getAccountTransactions to async/await with try/catch error handling |
The refactoring is clean, consistent, and follows TypeScript best practices. All error handling has been properly maintained, and the async/await conversion is correctly implemented throughout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kuan121
reviewed
Dec 13, 2025
| rippledSocket: XrplClient, | ||
| params: any, | ||
| ): Promise<any> => | ||
| rippledSocket.send(params).catch((error: any) => { |
Contributor
There was a problem hiding this comment.
Can this be converted to async/await as well?
kuan121
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR is a fast follow from #1269 to refactor the files converted to TS to use proper async/await structure instead of
thenstructure.There is no functionality change, only refactors.
Context of Change
Best practices, easier to read/write
Type of Change
Codebase Modernization
Already done ;)
Before / After
No changes
Test Plan
CI passes.