Skip to content

Conversation

@kuan121
Copy link
Contributor

@kuan121 kuan121 commented Dec 19, 2025

High Level Overview of Change

Fix a bug where token icon logo isn't rendered correctly when users provide an icon URL without HTTP/HTTPS protocol in metadata. For example,

{
  "asset_class": "rwa",
  "asset_subclass": "stablecoin",
  "ticker": "RLUSD",
  "name": "MPT RLUSD - Short",
  "desc": "Ripple's RLUSD using the MPT standard - Short",
  "icon": "s1.xrplmeta.org/icon/5CEA036903.png",
  "issuer_name": "Ripple",
  "uris": [
    ...
  ],
  "additional_info": {
    ...
  }
}

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

Codebase Modernization

  • Updated files to React Hooks
  • Updated files to TypeScript
  • Updated tests to React Testing Library

Before / After

Before - https://testnet.xrpl.org/mpt/00CB8B1D9A62293225214846706F863B5D1C75CDF1EC0C00
After - https://testnet.dev.ripplex.io/mpt/00CB8B1D9A62293225214846706F863B5D1C75CDF1EC0C00

Test Plan

const showMPTIssuanceId = !!ticker

// Convert logo URL to HTTP/HTTPS format (handles IPFS URLs)
const RenderedLogoUrl = logoUrl ? convertToHttpURL(logoUrl) : undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be in camel case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants