Remove R_RISCV_RVC_LUI #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R_RISCV_RVC_LUI is a binutil's internal relocation. We've never had a assembly syntax for the relocation, and there should be no object file that contains this relocation. This relocation has no valid use case. Closes riscv-non-isa#398
kito-cheng
requested review from
MaskRay,
Nelson1225,
jrtc27 and
kito-cheng
kito-cheng
approved these changes
Sep 27, 2023
Collaborator
kito-cheng
left a comment
kito-cheng
left a comment
There was a problem hiding this comment.
It's only used intermediate only, so remove that is good to me, thanks @rui314 :)
MaskRay
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R_RISCV_RVC_LUI is a binutil's internal relocation. We've never had a assembly syntax for the relocation, and there should be no object file that contains this relocation. This relocation has no valid use case.
Closes #398