Skip to content

Smcsps: Clarify that stack pointer swapping always operates on x2#823

Open
christian-herber-nxp wants to merge 1 commit intomasterfrom
821-issue-can-conditional-stack-pointer-swap-instructions-take-operands-other-than-sp
Open

Smcsps: Clarify that stack pointer swapping always operates on x2#823
christian-herber-nxp wants to merge 1 commit intomasterfrom
821-issue-can-conditional-stack-pointer-swap-instructions-take-operands-other-than-sp

Conversation

@christian-herber-nxp
Copy link
Copy Markdown
Collaborator

@pkennedyTT please review

@pkennedyTT
Copy link
Copy Markdown
Contributor

Thanks for the clarification! This is the opposite of what I had assumed.

The only suggestions I would make are:

  • Remove the "rd, rs" from the mnemonic description for mcspspush and scspspush (pp. 11, 13)
  • Replace "rd" and "rs" with "sp" (or "x2") in the behavior sections for all four instructions (pp. 11 - 14)
  • Remove the "sp, sp" operands from "mcspspop" in the behavior of "mipopret", likewise for "sipopret" (pp. 26 - 27)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue]: Can conditional stack pointer swap instructions take operands other than sp?

2 participants