move Docker image loading into reusable workflow for CI#1672
Open
jordancarlin wants to merge 1 commit intoriscv:mainfrom
Open
move Docker image loading into reusable workflow for CI#1672jordancarlin wants to merge 1 commit intoriscv:mainfrom
jordancarlin wants to merge 1 commit intoriscv:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the CI workflow by consolidating repetitive Docker image setup steps into a reusable composite action. The change reduces duplication across multiple regression test jobs and centralizes the management of the Docker image download and loading process.
Changes:
- Created a new composite action at
.github/actions/setup-docker-image/action.ymlthat encapsulates repository checkout, Docker image artifact download, and image loading steps - Removed the
never-runsjob (which was only used to keep renovate's download-artifact reference up-to-date) - Updated the workflow generator script to use the new composite action instead of generating the repetitive setup steps
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/actions/setup-docker-image/action.yml |
New composite action that performs repository checkout, downloads Docker image artifact, and loads the Docker image |
tools/test/regress-gh-template.yaml |
Template updated to use the new composite action and removed the obsolete never-runs job |
tools/test/gen_regress.rb |
Generator script updated to emit the new composite action reference instead of generating individual setup steps |
.github/workflows/regress.yml |
Generated workflow file with all test jobs now using the composite action for Docker setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dhower-qc
reviewed
Feb 18, 2026
Comment on lines
-57
to
-64
| never-runs: | ||
| # this just exists so that renovate can keep the download-artifact pointer up-to-date | ||
| # we use it for regressions later | ||
| runs-on: ubuntu-latest | ||
| if: "false" | ||
| steps: | ||
| - name: Use download-artifact | ||
| uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7 |
Collaborator
There was a problem hiding this comment.
Is this supposed to be here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.