feat(idl): add function return analysis to type checking#1732
feat(idl): add function return analysis to type checking#1732dhower-qc wants to merge 2 commits intoriscv:mainfrom
Conversation
f79c224 to
ec1e53c
Compare
|
@henrikg-qc FYI, this is going to enforce that every non-void function returns or terminates (forcing us to eliminate the c++ compiler warnings) |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (22.53%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1732 +/- ##
==========================================
- Coverage 70.87% 70.73% -0.14%
==========================================
Files 49 49
Lines 27714 27781 +67
Branches 6534 6572 +38
==========================================
+ Hits 19641 19652 +11
- Misses 8073 8129 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I presume this shouldn't be included.
ThinkOpenly
left a comment
There was a problem hiding this comment.
Not a terribly skilled review, but nothing screams out.
No description provided.