Skip to content

feat(idl): add function return analysis to type checking#1732

Open
dhower-qc wants to merge 2 commits intoriscv:mainfrom
dhower-qc:idl-return-analysis
Open

feat(idl): add function return analysis to type checking#1732
dhower-qc wants to merge 2 commits intoriscv:mainfrom
dhower-qc:idl-return-analysis

Conversation

@dhower-qc
Copy link
Copy Markdown
Collaborator

No description provided.

@dhower-qc dhower-qc requested a review from ThinkOpenly as a code owner March 11, 2026 19:26
@dhower-qc dhower-qc force-pushed the idl-return-analysis branch from f79c224 to ec1e53c Compare March 11, 2026 19:28
@dhower-qc
Copy link
Copy Markdown
Collaborator Author

@henrikg-qc FYI, this is going to enforce that every non-void function returns or terminates (forcing us to eliminate the c++ compiler warnings)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 22.53521% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.73%. Comparing base (76e076c) to head (bbb64fe).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
tools/ruby-gems/idlc/lib/idlc/ast.rb 22.85% 54 Missing ⚠️
tools/ruby-gems/idlc/lib/idlc/passes/prune.rb 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (22.53%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
- Coverage   70.87%   70.73%   -0.14%     
==========================================
  Files          49       49              
  Lines       27714    27781      +67     
  Branches     6534     6572      +38     
==========================================
+ Hits        19641    19652      +11     
- Misses       8073     8129      +56     
Flag Coverage Δ
idlc 74.70% <22.53%> (-0.22%) ⬇️
udb 63.62% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this shouldn't be included.

Copy link
Copy Markdown
Collaborator

@ThinkOpenly ThinkOpenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a terribly skilled review, but nothing screams out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants