Skip to content

chore(core-sdk): integrate dev.8 memory SDK [manual-release] - #103

Merged
luodaoyi merged 1 commit into
mainfrom
chore/core-sdk-dev8-memory
Oct 12, 2026
Merged

luodaoyi merged 1 commit into
mainfrom
chore/core-sdk-dev8-memory

Conversation

@luodaoyi

@luodaoyi luodaoyi commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem and change

Pin the CLI and packaged Rust wrapper to the published Core SDK 1.0.2-dev.8, integrating the shared-snapshot memory optimization from risense-ai/respire-core#15. CLI payload lifetime optimization #102 is already in the base.

Only two byte-identical lock files change. All seven targets retain the existing schema and redistribution approval; SDK version, official download URLs and manifest/archive SHA-256 pins advance together.

Based on main c574806, including #100. No server lock, deployment, proxy experiment, workflow, or unrelated source change. This PR is marked [manual-release]; no merge or release dispatch is performed by this integration task.

Validation

  • Independently verified all seven local release manifests and archives against both locks, including source revision 14bc1942d764b5205bb4f8e8ac45e07d3d68ad83 and ABI 65538. Lock SHA-256: cba7c933b7e62f3e0ab2d152adf0030e94d7f9f8fc4498878315a7f3a862beb0.
  • Downloaded published GNU x64 from a fresh empty directory using the unmodified scripts/fetch-core-sdk.mjs: pinned manifest/archive and all 276 payload hashes passed. Exact inventory, canonical ABI header and release license verified.
  • The published GNU static library is byte-identical to the previously tested optimization binary (SHA-256 c6708e1c7b72dfe31c0ebbe198a7419a3d00fbc1d921cb99c7ee11d1d21eb6fa). Release metadata/notices differ from the internal test package; this is not a claim that entire packages are identical.
  • Real C and Rust native callers passed capabilities, prepare/query/remember_candidates with a synthetic test-hash model and 1,000 buffer ownership cycles each.
  • cargo test --locked --offline -p respire_core_sdk --lib: 8 passed. Two model-recovery tests return early without a real model fixture; their real-model branches were not exercised.
  • Isolated Rust wrapper consumer initialized the public SDK and passed ABI/capabilities, synthetic prepare and error recovery. Fresh offline dependency resolution initially encountered a cached yanked yoke dependency; seeding the isolated consumer with the unchanged repository Cargo.lock resolved it.
  • cargo build --release --locked --offline -p respire: passed with the default production features and panic/unwind configuration.
  • cargo test --release --locked --offline -p respire --test version_flag: 4 passed.
  • Built CLI passed status/autostart, graceful restart and shutdown against an isolated synthetic home.
  • scripts/test-core-payload-lifetime.py: all 5 actual-wrapper tests passed; both intentional negative controls detected.
  • check-sdk-release, npm artifact manifest, release-publication tests (13), registry-publication tests (23), and git diff --check passed.
  • Independent AI review: APPROVE for the exact two-lock diff on the new main base; no blocking findings. Remote branch contents verified identical to the tested worktree.
  • Historical internal check-sdk-library.mjs rejects top-level LICENSE.txt because of its old path whitelist. The sole exception was independently hashed; current fetch and stage-core-runtime support and preserve it. No checker or source was weakened.

All data/fixtures used here are synthetic. This PR does not claim a fresh full-workspace coverage run, new real-model performance measurements, or native execution on all seven platforms. Exact-head CI remains required.

Compatibility and migration

ABI remains 65538; no CLI, JSON/RPC, storage/index/config or public Rust API changes. No data migration. Roll back by restoring both locks together to their prior pins if needed.

Applicable checks

  • Focused change and motivation recorded.
  • Relevant checks and verification gaps recorded.
  • Compatibility/migration impact addressed.
  • No credentials, databases or private user memories in this PR or its evidence.

Summary by CodeRabbit

  • Updates
    • Updated the SDK version to 1.0.2-dev.8 across all seven supported targets. Download references and verification details now correspond to this version. Supported platforms and redistribution approval remain unchanged.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: risense-ai/respire-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 04e53759-90a8-4a60-b5d3-61899f8a4e01

📥 Commits

Reviewing files that changed from the base of the PR and between c574806 and 19b04d4.


📒 Files selected for processing (2)
  • crates/core-sdk/core-sdk.lock.json
  • sdk/core-sdk.lock.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.



📝 Walkthrough

Walkthrough

Both SDK lockfiles now reference SDK version 1.0.2-dev.8 for all seven target platforms. The manifest and archive URLs and SHA-256 values were updated. Redistribution approvals remain unchanged.

Changes

SDK lockfile release update

Layer / File(s) Summary
Update SDK release references
crates/core-sdk/core-sdk.lock.json, sdk/core-sdk.lock.json
All seven target records in both lockfiles now reference version 1.0.2-dev.8 and its updated URLs and SHA-256 values. Redistribution settings remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 19b04

Both lockfiles agree, and the seven pinned SDK downloads match their published hashes. No concrete build or runtime regression is established by this metadata-only change.

Architecture Summary

Architecture risk: 🔵 Low · up to 19b04

The change affects 2 systems.

Changed systems: crates, sdk

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — crates (service) was modified; 1 changed file maps to changed impact.
  • observed — sdk (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in crates/core-sdk/core-sdk.lock.json: The x86_64 Windows MSVC entry now references SDK 1.0.2-dev.8 and its updated manifest and archive URLs and SHA-256 values; redistribution remains approved.
  • observed — Modified behavior in crates/core-sdk/core-sdk.lock.json: The aarch64 Windows MSVC entry now references SDK 1.0.2-dev.8 and its updated manifest and archive URLs and SHA-256 values; redistribution remains approved.
  • observed — Modified behavior in crates/core-sdk/core-sdk.lock.json: The aarch64 Apple Darwin entry now references SDK 1.0.2-dev.8 and its updated manifest and archive URLs and SHA-256 values; redistribution remains approved.
  • observed — Modified behavior in crates/core-sdk/core-sdk.lock.json: The x86_64 Linux GNU entry now references SDK 1.0.2-dev.8 and its updated manifest and archive URLs and SHA-256 values; redistribution remains approved.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the Core SDK dev.8 integration and accurately reflects the lock-file updates.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@luodaoyi
luodaoyi merged commit 028d0a8 into main Oct 12, 2026
5 checks passed
@luodaoyi
luodaoyi deleted the chore/core-sdk-dev8-memory branch October 14, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant