fix: make rustc nigthly work by drop cursor_remaining#18764
Closed
yihong0618 wants to merge 5 commits intorisingwavelabs:mainfrom
yihong0618:hy/fix_nightly
Closed
fix: make rustc nigthly work by drop cursor_remaining#18764yihong0618 wants to merge 5 commits intorisingwavelabs:mainfrom yihong0618:hy/fix_nightly
yihong0618 wants to merge 5 commits intorisingwavelabs:mainfrom
yihong0618:hy/fix_nightly
Conversation
It only use this nightly feature in unit tests that in `test_bincode_deserialize_many` assert!(buf.is_empty()) its a break change in Cursor nightly feature, so comments this and add FIXME to make rustc nightly work. Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Contributor
Author
|
nightly down again by rust tool chain update |
Contributor
|
I think it's already resolved in #19170. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It only use this nightly feature in unit tests that in
test_bincode_deserialize_manyassert!(buf.is_empty()) its a break change in Cursor nightly feature, so comments this and add FIXME to make rustc nightly work.The nightly feature bring from #9721
and the only used code is in test and assert function, I choose to comment it and and add FIXME for now.
This rustc discuss can check rust-lang/rust#109174
is_empty() doc: https://doc.rust-lang.org/stable/std/io/struct.Cursor.html#method.is_empty
passed ci: https://github.com/yihong0618/risingwave/actions/runs/11099278294/job/30833253564
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.