[cgonyeo]

docker2aci recently gained support for the v2 docker HTTP API. Bumping
the version used by rkt to pull that into here.

[jonboulle]

you hurt CI's feelings

[cgonyeo]

Interesting:

=== RUN TestNonRootFetchRmGcImage
--- FAIL: TestNonRootFetchRmGcImage (4.60s)
    rkt_non_root_test.go:94: Running rkt install
    rkt_non_root_test.go:109: Running /home/runner/rkt/builds/build-rkt-src-v222/build-rkt-0.12.0+git/bin/rkt --dir=/tmp/datadir-258904928 --local-config=/tmp/localdir-763737919 --system-config=/tmp/systemdir-093519250 image gc
    rkt_non_root_test.go:114: Running /home/runner/rkt/builds/build-rkt-src-v222/build-rkt-0.12.0+git/bin/rkt --dir=/tmp/datadir-258904928 --local-config=/tmp/localdir-763737919 --system-config=/tmp/systemdir-093519250 image rm sha512-cf933df66addd9008fe28d50d97b01c1
    rkt_non_root_test.go:123: Running /home/runner/rkt/builds/build-rkt-src-v222/build-rkt-0.12.0+git/bin/rkt --dir=/tmp/datadir-258904928 --local-config=/tmp/localdir-763737919 --system-config=/tmp/systemdir-093519250 image rm sha512-cfb3d8cb872d7da7aae3265e3cba128e
    rkt_tests.go:281: didn't receive expected output "successfully removed": rkt: error removing aci for image ID "sha512-cfb3d8cb872d7da7aae3265e3cba128e": permission denied, are you root or the owner of the image?

        rkt: 1 image(s) cannot be removed

        rkt: error(s) found while removing images

    rkt_tests.go:125: rkt didn't terminate correctly: exit status 1
        Output:

I don't see why docker2aci would impact that test...

[jonboulle]

semaphore looks fishy. kicking it.

[jonboulle]

  error downloading ACI: Get https://github.com/coreos/etcd/releases/download/v2.1.2/etcd-v2.1.2-linux-amd64.aci: dial tcp: lookup github.com: no such host

hmph

[alban]

Semaphore is happy now. LGTM

[jonboulle]

Sanity check, is this (V2) flow actually covered by one of the functional tests?

[iaguis]

Sanity check, is this (V2) flow actually covered by one of the functional tests?

We fetch docker images from the docker hub in TestFetch and they use v2 so yes.

> sudo rkt --insecure-options=image run docker://busybox
rkt: using image from local store for image name coreos.com/rkt/stage1-coreos:0.12.0+gitb57536f
rkt: remote fetching from url docker://busybox
Downloading sha256:55dc925c23d: [==============================] 674 KB/674 KB 
Downloading sha256:a3ed95caeb0: [==============================] 32 B/32 B