Skip to content

pytest 3.6 support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ostcar opened this issue Jul 29, 2018 · 2 comments · Fixed by #5
Closed

pytest 3.6 support #3

ostcar opened this issue Jul 29, 2018 · 2 comments · Fixed by #5

Comments

@ostcar
Copy link

ostcar commented Jul 29, 2018

I am new to pytest, so maybe I misunderstand something.

I installed your plugin and got:

...
TERNALERROR>   File ".../site-packages/pytest_django_ordering/plugin.py", line 13, in get_marker_transaction
INTERNALERROR>     return marker.transaction
INTERNALERROR> AttributeError: 'MarkInfo' object has no attribute 'transaction'

I could fix this by replacing marker.transaction with marker.kwargs['transaction']
@ostcar ostcar mentioned this issue Jul 29, 2018
Closed
@rlucioni
Copy link
Owner

Thanks for the heads-up @ostcar. Assuming that change also works for older versions of pytest, I'd be happy to accept a PR.

@rebeccacremona rebeccacremona mentioned this issue Jan 23, 2019
Merged
@rlucioni
Copy link
Owner

@ostcar just wanted to let you know that this has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support modern pytest and pytest-django rebeccacremona/pytest-django-ordering
2 participants
@rlucioni @ostcar