Set ecbuild module path so CMakeModules FindNetCDF takes precedence #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmontuoro
approved these changes
Jun 17, 2021
| cmake .. \ | ||
| -DCMAKE_INSTALL_PREFIX=$prefix \ | ||
| -DCMAKE_MODULE_PATH="${CMAKEMODULES_ROOT}/Modules;${ESMA_CMAKE_ROOT}" \ | ||
| -DCMAKE_MODULE_PATH="${ESMA_CMAKE_ROOT};${CMAKEMODULES_ROOT}/Modules;${ECBUILD_ROOT}/share/ecbuild/cmake" \ |
There was a problem hiding this comment.
I don't think it is a good idea to send the esma cmake and ecbuild from here. I am sure it is explicitly included in mapl.
Owner
There was a problem hiding this comment.
ESMA_CMAKE_ROOT is required to find ESMA_cmake. The esma.cmake script (included in MAPL/CmakeLists.txt) uses find_package(ecbuild) to load ecBuild.
Author
There was a problem hiding this comment.
ecbuild is handled internally, but if you set it here then it doesn't get set again when ecbuild is loaded and override FindNetCDF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmontuoro I figured out a way to make our FindNetCDF take precedence, and I think it's a better approach than directly passing nc-config flags.