Adjust breadth interface hooks #5429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
reviewed
Sep 9, 2025
| end | ||
|
|
||
| # hook for breadth-first implementations to signal when collecting results. | ||
| def collect_result(result_name, result_value) |
There was a problem hiding this comment.
? for predicate method?
Suggested change
| def collect_result(result_name, result_value) | |
| def collect_result?(result_name, result_value) |
There was a problem hiding this comment.
I assume you skipped it because it can have side effects. Probably better as is 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to the breadth runtime interface... plugs a hole where argument errors were leaking out. This OO interface also feels a bit nicer by keeping the focus on the object scope rather than the runtime.
So – in the object sequence spanning
evaluate_selection ... evaluate_selection_with_resolved_keyword_args, we basically just need to offer all values toselection_result.collect_resultprior to callingcontinue_value. Seem reasonable?