Skip to content

typo: http acme dir #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app-server/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ FROM php:8.3-alpine
# https://github.com/mlocati/docker-php-extension-installer
# https://github.com/docker-library/docs/tree/0fbef0e8b8c403f581b794030f9180a68935af9d/php#how-to-install-more-php-extensions
RUN --mount=type=bind,from=mlocati/php-extension-installer:2,source=/usr/bin/install-php-extensions,target=/usr/local/bin/install-php-extensions \
install-php-extensions @composer-2 opcache zip intl sockets profobuf
install-php-extensions @composer-2 opcache zip intl sockets protobuf

COPY --from=roadrunner /usr/bin/rr /usr/local/bin/rr

Expand Down
2 changes: 1 addition & 1 deletion http/http.md
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ http:
# directory to store your certificate and key from the LE
#
# Default: rr_cache_dir
certs_dir: rr_le_certs
cache_dir: rr_le_certs
# Your email
#
# Mandatory. Error on empty.
Expand Down
6 changes: 3 additions & 3 deletions kv/overview-kv.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ otel:

{% endcode %}

After that, you can see traces in your [Jaeger](https://www.jaegertracing.io/), [Uptrace](https://uptrace.dev/), [Zipkin](https://zipkin.io/) or any
other opentelemetry compatible tracing system.
After that, you can see traces in your [Dash0](https://www.dash0.com/), [Jaeger](https://www.jaegertracing.io/), [Uptrace](https://uptrace.dev/),
[Zipkin](https://zipkin.io/) or any other opentelemetry compatible tracing system.


## Configuration
Expand Down Expand Up @@ -356,7 +356,7 @@ To make it easy to use the KV proto API in PHP, we provide
a [GitHub repository](https://github.com/roadrunner-php/roadrunner-api-dto), that contains all the generated PHP DTO
classes proto files, making it easy to work with these files in your PHP application.

- [API](https://github.com/roadrunner-server/api/blob/master/kv/v1/kv.proto)
- [API](https://github.com/roadrunner-server/api/blob/master/proto/kv/v1/kv.proto)

### RPC API

Expand Down
8 changes: 4 additions & 4 deletions php/worker.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ while (true) {
//
// Reply by the 500 Internal Server Error response
$psr7->respond(new Response(500, [], 'Something Went Wrong!'));

// Additionally, we can inform the RoadRunner that the processing
// of the request failed.
$psr7->getWorker()->error((string)$e);
// of the request failed. Use error instead of response to indicate
// worker error, do not use both.
// $psr7->getWorker()->error((string)$e);
}
}
```
Expand Down Expand Up @@ -222,7 +223,6 @@ final class HttpDispatcher implements DispatcherInterface
$worker->respond(new Response(200, [], 'Hello RoadRunner!'));
} catch (\Throwable $e) {
$worker->respond(new Response(500, [], 'Something Went Wrong!'));
$worker->getWorker()->error((string)$e);
}
}
}
Expand Down