-
Notifications
You must be signed in to change notification settings - Fork 16
chore: Nats
duplicated messages notice
#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Nats
duplicated messages notice
#36
Conversation
Typo on protobuf
…S_PROMETHEUS` env" (roadrunner-server#26) This reverts commit 0c3ba36.
WalkthroughThe documentation for the NATS driver in Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
queues/nats.md (1)
79-80
: LGTM! Consider adding a warning emoji for better visibility.The notice about unique streams is well-placed and provides valuable guidance to prevent duplicate message consumption. To make this important notice even more visible to users, consider adding a warning emoji at the start.
-> Notice: To avoid duplicate message consumption in NATS-driven pipelines, use unique streams for each pipeline. Sharing streams can lead to repeated processing of the same messages. +> ⚠️ Notice: To avoid duplicate message consumption in NATS-driven pipelines, use unique streams for each pipeline. Sharing streams can lead to repeated processing of the same messages.
Thank you, @shellphy 👍 |
refer to: https://github.com/orgs/roadrunner-server/discussions/2049#discussioncomment-11334380
Summary by CodeRabbit