Skip to content

chore(tests): drive RPC over goridge net/rpc again#223

Merged
rustatian merged 1 commit into
masterfrom
revert/connectrpc
Jul 15, 2026
Merged

chore(tests): drive RPC over goridge net/rpc again#223
rustatian merged 1 commit into
masterfrom
revert/connectrpc

Conversation

@rustatian

Copy link
Copy Markdown
Member

Part of the org-wide Connect-RPC revert: test helpers drive the RPC surface over goridge net/rpc again, keeping the current api-go message set. Plugin deps in tests/go.mod are pinned to the revert branches (pseudo-versions to be replaced by tags). No changes outside tests/.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copilot AI review requested due to automatic review settings July 14, 2026 21:31
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rustatian, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 42a94648-0999-4e23-888c-ef35ad45f140

📥 Commits

Reviewing files that changed from the base of the PR and between e334c5e and fdcb951.

⛔ Files ignored due to path filters (1)
  • tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • tests/go.mod
  • tests/helpers/helpers.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/connectrpc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the test helper RPC client used by the tests/ module to drive the RoadRunner Jobs RPC surface over goridge net/rpc again (as part of the Connect-RPC revert), while keeping the current api-go message set.

Changes:

  • Replaced Connect-RPC HTTP/2 client usage with a goridge net/rpc client in tests/helpers/helpers.go.
  • Updated helper calls to invoke RPC methods via client.Call("jobs.<Method>", ...) and adjusted response handling accordingly.
  • Updated tests/go.mod / tests/go.sum to remove Connect dependencies and pin RoadRunner dependencies to revert-branch pseudo-versions.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/helpers/helpers.go Switches test RPC helpers from Connect-RPC over HTTP/2 to goridge net/rpc and updates method invocations accordingly.
tests/go.mod Removes Connect-RPC deps; adds/pins RoadRunner modules (including goridge) to revert pseudo-versions.
tests/go.sum Updates checksums to match removed Connect deps and newly pinned pseudo-versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/helpers/helpers.go
@rustatian
rustatian merged commit 48d68b9 into master Jul 15, 2026
7 of 8 checks passed
@rustatian
rustatian deleted the revert/connectrpc branch July 15, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants