chore(tests): drive RPC over goridge net/rpc again#223
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the test helper RPC client used by the tests/ module to drive the RoadRunner Jobs RPC surface over goridge net/rpc again (as part of the Connect-RPC revert), while keeping the current api-go message set.
Changes:
- Replaced Connect-RPC HTTP/2 client usage with a goridge
net/rpcclient intests/helpers/helpers.go. - Updated helper calls to invoke RPC methods via
client.Call("jobs.<Method>", ...)and adjusted response handling accordingly. - Updated
tests/go.mod/tests/go.sumto remove Connect dependencies and pin RoadRunner dependencies to revert-branch pseudo-versions.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/helpers/helpers.go | Switches test RPC helpers from Connect-RPC over HTTP/2 to goridge net/rpc and updates method invocations accordingly. |
| tests/go.mod | Removes Connect-RPC deps; adds/pins RoadRunner modules (including goridge) to revert pseudo-versions. |
| tests/go.sum | Updates checksums to match removed Connect deps and newly pinned pseudo-versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Part of the org-wide Connect-RPC revert: test helpers drive the RPC surface over goridge net/rpc again, keeping the current api-go message set. Plugin deps in tests/go.mod are pinned to the revert branches (pseudo-versions to be replaced by tags). No changes outside tests/.