feature: allow specifying wildcards in the grpc.proto setting#90
Conversation
|
Hey @MaxSem 👋🏻 Oh, I never saw this feature request 😢 Next time if that is something related to the server, please, send it to the https://github.com/roadrunner-server/roadrunner repository 👍🏻 |
2be4e23 to
4c647f5
Compare
Signed-off-by: Max Semenik <maxsem.wiki@gmail.com>
|
Thanks @MaxSem 👍🏻 |
|
Hi! It looks like it only works for plain wildcards (e.g. not recursive). The following, for example, wouldn't work: proto:
- "src/Support/Contracts/**/*.proto"Another option I wanted to use is a "glob brace": proto:
- "src/Support/Contracts/{,*/,*/*/,*/*/*/}*.proto"In this configuration, the inclusion of nested directories is defined for each level of deep. Yet, this feature doesn't seem to be enabled. If we had used PHP's The only way I've managed to make it work is by following: proto:
- "src/Support/Contracts/*/*/*/*.proto"
- "src/Support/Contracts/*/*/*.proto"
- "src/Support/Contracts/*/*.proto"It explicitly lists each glob pattern separately, one item per level of deep. This's working, but IMO implementing |
|
Hey @rela589n 👋🏻 |
|
Where could I create a ticket? |
Reason for This PR
ref: roadrunner-php/grpc#14
In large projects, maintaining the list of protofiles becomes a chore, allow using filename wildcards (e.g. path/to/*.proto)
Description of Changes
Expand wildcards in Config.InitDefaults()
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.